Delete blank-java and move its contents to java-events. #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The blank-java example is just a Lambda function that handles SQSEvent objects. - Moved this example to inside the java-events folder. - The Lambda developer guide now must remove all references to blank-java. - Tested this change using the sqs path, as well as ensured current examples still work.
|
I guess "blank" is kind of a misnomer as it's not the simplest example. It's part of a series of examples that shows a common set of functionality for each language. Removing it makes that topic seem incomplete. Since the SQS event handler is redundant, maybe there's a better use case? It might be interesting to show a different type of input, such as a plain string, binary object, or unmodeled JSON. |
|
Ah I see, once you showed me the page it does indeed look incomplete. I noticed the other language examples simply use the Lambda client to display AccountSettings. Do you think I can add that as the blank-java example too? |
|
yes I think that's a fine use case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Just consolidating the Lambda code examples. The previous blank-java example wasn't really a "blank" example. It contains skeleton code to handle SQSEvent objects, similar to other examples in the java-events collection, so this pull request just moves it there (and removes blank-java entirely).
The Lambda developer guide will then need to remove all references to the blank-java example.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.